igl Possible re-edit after commit 6b13876 to samples/wasm/CMakeLists.txt as it breaks tiny sample build on Linux

samples/wasm/CMakeLists.txt adds a demo sourced from Tiny.cpp, but the actual file is named tiny.cpp, which caused building issues for the tiny sample:

add_demo("Tiny" "${IGL_ROOT_DIR}/samples/wasm/igl.html")

[PS: Hi! It is my very first time contributing to open source. If you've got time, please share if I should or should not have included something in this description. Thanks!]

Jul 14 '23 05:07 KaivalyaD

Unfortunately we can't handle file renames that just change the case of the filename. You'll need to fix the CMake files instead.

Jul 14 '23 05:07 EricGriffith

Thanks, I've changed the cmake file instead

Jul 14 '23 05:07 KaivalyaD

This issue might have arose because Win32 ignores filename cases while others (I am using linux) aren't so forgiving. Seems to have caused quite nasty issues in the past:

https://stackoverflow.com/questions/33998669/windows-ntfs-and-case-sensitivity https://stackoverflow.com/questions/59393782/cmake-adding-case-insensitive-source-files

Jul 14 '23 08:07 KaivalyaD

@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Jul 18 '23 16:07 facebook-github-bot

Fixed in https://github.com/facebook/igl/commit/f5289e26644d82f5a12796b7f169239ed6acfd16

Jul 19 '23 03:07 corporateshark