igl icon indicating copy to clipboard operation
igl copied to clipboard

【Opengl】The DeviceFeatureLimits::BufferAlignment is not always equals 16 byte on OpenGL backend.

Open vinsentli opened this issue 10 months ago • 3 comments

The DeviceFeatureLimits::BufferAlignment is not always equals 16 byte on OpenGL backend. For example , on iOS phone is 64, on iOS simulator is 256. So use glContext_.getIntegerv(GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT, &tsize) to get the value is better.

vinsentli avatar Apr 30 '24 08:04 vinsentli

@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 30 '24 17:04 facebook-github-bot

@corporateshark Can this pull request about OpenGL be merged?

vinsentli avatar May 05 '24 05:05 vinsentli

@vinsentli This PR triggered some errors with SwiftShader. We are looking into it.

corporateshark avatar May 05 '24 06:05 corporateshark

@corporateshark merged this pull request in facebook/igl@004c6b580fee3e7d4dafdb7d634f86dba50c5a86.

facebook-github-bot avatar Jun 27 '24 01:06 facebook-github-bot