igl icon indicating copy to clipboard operation
igl copied to clipboard

Does DeviceFeatureLimits::BufferAlignment mean GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT?

Open vinsentli opened this issue 10 months ago • 2 comments

Does DeviceFeatureLimits::BufferAlignment mean GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT?

If it is , the BufferAlignment on iOS Simulator for metal, it is 256 bytes. And On iOS Device, its is 16 bytes.

https://developer.apple.com/documentation/metal/developing_metal_apps_that_run_in_simulator 【When you set arguments for the render or compute command, align constant buffer offsets to 256 bytes.】

image

vinsentli avatar Apr 22 '24 01:04 vinsentli

@vinsentli Thanks for pointing this out! I will take a closer look this week.

corporateshark avatar Apr 22 '24 02:04 corporateshark

@corporateshark I have pull two request to fix it. https://github.com/facebook/igl/pull/113 https://github.com/facebook/igl/pull/114

vinsentli avatar Apr 30 '24 09:04 vinsentli