hhvm

hhvm copied to clipboard

I am creating a test triggering `hh_client --lint --json` against some temporary files. The content of the temporary source file is like ``` /* * Copyright (c) 2017-present, Facebook, Inc....

Atry

[ Runtime | Extension ] json_decode parses invalid JSON strings and returns a result for them

1

**Describe the bug** When given an invalid JSON string which is defective in one of the manners described below, `json_decode()` returns a result. This JSON is not strictly valid according...

lexidor

We currently do a pretty nasty trick to emulate `execvpe` on MacOS: https://github.com/facebook/hhvm/blob/ceb300a5bf2411b07f7907bd1a613583901b78b7/hphp/util/process.cpp#L644-L657 There's two ways we could clean this up: - Set the Apple-specific `POSIX_SPAWN_SETEXEC` flag just to replace...

fredemmott

Create async version of curl_init_pooled

6

### HHVM Version 3.18.1 ### Standalone code, or other way to reproduce the problem ````

eryi

[ hh_client --lint ] False positive for 5607, equality checks a generic value to a typed value is not always false

1

**Describe the bug** Given the expression `$expression_resolving_to_generic_type === $expression_resolving_to_a_known_type`, lint rule 5607 should not emit an error if the generic type has any overlap with the known type. **Standalone code,...

lexidor

[ TypeChecker | Regression? ] It is nolonger an error to forget to use the $$ variable on the RHS of a |>

4

**Describe the bug** In hhvm 4.27, forgetting to use the `$$` variable on the RHS of a `|>` operator, would be a typechecker error. _Naming[2069] This expression does not contain...

lexidor

Given this code ```hack class ATest {} class ATestChild extends ATest { public function doThing(): void {} } function foo(dict $arr) { if (HH\Lib\C\contains_key($arr, 'b') && $arr['b'] is ATestChild) {...

muglug

**Describe the bug** Type coverage is not correct in files with `Shapes::idx()` calls. **Standalone code, or other way to reproduce the problem** ```HACK function full_coverage(): void { idx(vec[], 0); idx(vec[],...

lexidor

Add the optional `opaque` key to TypeStructure

4

```HACK newtype A = int; =\HH\ReifiedGenerics\get_type_structure(); Dict ( [kind] => 1 [opaque] => true [alias] => "A" ) ```

lexidor

Declare SQL format string interfaces at runtime

1

Fixes #8873

lexidor