vsdebug: Fix double-closing listener FDs

Open mszabo-wikia opened this issue 2 weeks ago • 3 comments

While working on D88186184, I noticed that we were closing the listener FDs for the vsdebug server in both waitForConnection and listenForClientConnection. It does not seem to be causing issues in local testing but it could be a problem if the FD gets reused in a different thread in the meantime. waitForConnection is only called at the end of listenForClientConnection so closing the FDs only at the end of listenForClientConnection should be fine.

Dec 03 '25 18:12 mszabo-wikia

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

Dec 04 '25 02:12 facebook-github-bot

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D88280004. (Because this pull request was imported automatically, there will not be any future comments.)

Dec 04 '25 02:12 meta-codesync[bot]

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

Dec 10 '25 11:12 facebook-github-bot