hhvm icon indicating copy to clipboard operation
hhvm copied to clipboard

Fix trivial OSS test failures

Open mszabo-wikia opened this issue 5 months ago • 1 comments

Address some straightforward test failures in HHVM OSS:

  • Gate tests for internal Meta extensions behind appropriate runif checks.
  • Set -vPHP7.EngineExceptions=false for some tests that assume this, as this knob defaults to false in internal builds but to true in OSS.
  • Skip tests that exercise fb_(un)serialize() outside internal builds, since FBSerialize was removed from HHVM OSS in D46525242.
  • Remove a hardcoded fbcode reference.

mszabo-wikia avatar Jun 16 '25 01:06 mszabo-wikia

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

facebook-github-bot avatar Jun 16 '25 01:06 facebook-github-bot

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Oct 06 '25 11:10 facebook-github-bot