hhvm
hhvm copied to clipboard
Update systemlib generation to support precompiled systemlibs
Since D46606416, we include precompiled unitemitters rather than raw Hack source files for systemlibs into the HHVM binary. This requires corresponding updates to the OSS build system.
- Update embed_all_systemlibs() and embed_systemlibs_byname() to invoke HHVM to compile systemlibs, and update section name generation to match.
- Update systemlib generation to correctly look for systemlib sources under hphp/runtime/ext/core instead of hphp/system after they were moved in D46164829.
- Make tc-print depend on HHVM, since the hhvm binary is required to compile and embed systemlibs into tc-print.
- Fix apparently erroneous contains() check (added in D65835121) in compiler-systemlib.cpp that checks for
filebut then tries to access"ext_" + file. This is erroring in OSS, since all extension systemlibs are named ext_something.php, not something.php.
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D76160386. (Because this pull request was imported automatically, there will not be any future comments.)