hhvm icon indicating copy to clipboard operation
hhvm copied to clipboard

Fix compilation error with OpenSSL 3

Open Atry opened this issue 2 years ago • 2 comments

Summary: In OpenSSL 3, EVP_PKEY_get0_* functions now return const pointers, breaking existing usage depending on mutable pointers returned by OpenSSL 1.x. This diff fix the errors

  1. Use auto type for return type of EVP_PKEY_get0_* functions instead of mutable pointer types.
  2. Some EVP_PKEY_get0_RSA are replaced with EVP_PKEY_get1_RSA in order to get a mutable pointer with the ownership.

See https://www.openssl.org/docs/man3.0/man7/crypto.html#LIBRARY-CONVENTIONS for the get_0 conventions

Differential Revision: D40942193

Atry avatar Nov 02 '22 16:11 Atry

This pull request was exported from Phabricator. Differential Revision: D40942193

facebook-github-bot avatar Nov 02 '22 16:11 facebook-github-bot

Hi @Atry!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 02 '22 15:12 facebook-github-bot