hhvm icon indicating copy to clipboard operation
hhvm copied to clipboard

Add LibUnwind as a dependency of glog::glog (#1058)

Open Atry opened this issue 3 years ago • 2 comments
trafficstars

Summary: X-link: https://github.com/facebook/watchman/pull/1058

X-link: https://github.com/facebookincubator/reindeer/pull/5

X-link: https://github.com/facebook/sapling-staging/pull/8

X-link: https://github.com/facebookexperimental/edencommon/pull/5

X-link: https://github.com/facebookincubator/fizz/pull/82

X-link: https://github.com/facebookincubator/velox/pull/2487

X-link: https://github.com/facebookincubator/hsthrift/pull/101

X-link: https://github.com/facebookincubator/katran/pull/172

X-link: https://github.com/facebookincubator/mvfst/pull/273

X-link: https://github.com/fairinternal/AIRStore/pull/38

LibUnwind is a dependency of glog according to objdump. This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library glog::glog as an element in the IMPORTED_LINK_INTERFACE_LIBRARIES property.

Without this diff, there will be a linker error like this:

/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext'
//usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

Differential Revision: D39340650

Atry avatar Sep 08 '22 22:09 Atry

This pull request was exported from Phabricator. Differential Revision: D39340650

facebook-github-bot avatar Sep 08 '22 22:09 facebook-github-bot

Hi @Atry!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 02 '22 15:12 facebook-github-bot

This pull request has been merged in facebook/hhvm@2ee29bb2db6c31af6c9423d72dcb96aaff11f777.

facebook-github-bot avatar Mar 25 '24 23:03 facebook-github-bot