hhvm
hhvm copied to clipboard
facebook
Build HHVM packages both as an impure derivation and an ordinary derivation
The impure derivation is built in a Nix sandbox, which ensures the build script did not accidentally reference any non-Nix dependencies.
The default package is not an impure derivation so it is cacheable, but it must be built without a Nix sandbox because it requires internet access.
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Hi @Atry!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!