hhvm icon indicating copy to clipboard operation
hhvm copied to clipboard

Spelling

Open jsoref opened this issue 3 years ago • 7 comments

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/hhvm/commit/e308e3fced995da691531036c61baa6f9cd373a6#commitcomment-66884198

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/hhvm/commit/dc6a358330dd6bdd7f794526304a04f71d1a363b

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

I've annotated this PR. I'm happy to drop changes to files, drop specific terms, or split things as requested, although this may take some time.

I normally take efforts to exclude third party directories, but for various reasons I didn't here. I'm quite happy to drop any particular files / directories, just let me know where they live. Also, if there's an upstream for them, I'm generally happy to queue fixes for them.

jsoref avatar Feb 17 '22 12:02 jsoref

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Feb 18 '22 06:02 facebook-github-bot

We might not want to make API changes even if it's a typo.

Atry avatar Feb 18 '22 06:02 Atry

Because there are many risky changes, like change of API and constant values, this PR can hardly pass CI unless excluding all the risky changes or splitting into small PRs.

Atry avatar Feb 18 '22 18:02 Atry

Happy to split, just provide a recommendation of how. I'm used to doing such changes over long periods of time.

I could for instance try to only change Docs in one PR, or comments in one PR, or locals in one PR.

Alternatively, I could try to change things on a per directory basis.

jsoref avatar Feb 18 '22 20:02 jsoref

@jsoref has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Feb 21 '22 23:02 facebook-github-bot

@jsoref has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Mar 24 '22 03:03 facebook-github-bot

@jsoref has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Mar 24 '22 04:03 facebook-github-bot