hhvm
hhvm copied to clipboard
facebook
Enable SSE4.2 by default in open source builds
Summary: It looks like we depend on SSE 4.2 implicitly already, might as well do it explicitly to enable performance improvements. Changing the baseline cpu build for our MacOS builds led to a 20x improvement in some real-world cases.
I plan to remove the option if there isn't negative feedback about it.
Reviewed By: ricklavoie
Differential Revision: D30074423
Hi @fredemmott!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!