hhvm icon indicating copy to clipboard operation
hhvm copied to clipboard

Aarch64 - Disable executable stacks

Open jim-saxman opened this issue 6 years ago • 2 comments

Summary: This patch marks assembly files as having a non-executable stack. It also updates the Aarch64 gold linker's command line to force the stack to be non-execuatable and throw a warning if the stack becomes executable in the future.

There are no new unit test case regressions with this patch, and the time to run the unit test suite is greatly reduced.

jim-saxman avatar Aug 27 '18 20:08 jim-saxman

Hi @mxw, @swalk-cavium, can you please review?

jim-saxman avatar Aug 27 '18 20:08 jim-saxman

@jim-saxman - LGTM

swalk-cavium avatar Aug 27 '18 20:08 swalk-cavium