hermes
hermes copied to clipboard
Implement `TypedArray.prototype.toSorted`
Summary
This PR implements ES2023 TypedArray.prototype.toSorted
method.
See also:
- PR for
TypedArray.prototype.toReversed
: #1366 - PR for
TypedArray.prototype.with
: #1365
I am creating separate PRs for each method in case there are any suggestions or change requests from your side, so that PRs are more independent.
Test Plan
Code is annotated with algorithm steps from EcmaScript specification for easier verification and maintenance. I also added tests to verify that methods work as intended. There might be some more edge cases that might be covered based on your experience.
$ echo "new Int8Array([3, 1, 2]).toSorted()" | ./bin/hermes
# >> Int8Array [ 1, 2, 3 ]
Same issue here, the links on the buttons don't look right to me! Can't find anywhere to download the win version....
Edit:
Found link on 'way back when machine' seems like they unsupported.... https://github.com/facebook/flipper/releases?page=2
Edit 2:
It's awful, ended up using the experimental debugger features on 0.73 >
npx react-native start --experimental-debugger
Not sure what I'll do with legacy projects but that's a future me problem.
How are you checking the network logs in experimental debugger ?
That is a issue but not for the project I'm on at the moment, I test my endpoints using PostMan so at the moment I don't need to query the network logs
refer issue #5619