hermes icon indicating copy to clipboard operation
hermes copied to clipboard

RFC: Uncomment Object Built-Ins?

Open sebholl opened this issue 2 years ago • 1 comments

Genuine request for comment - curious why particular built-ins have been commented out?

My only guess is that some of these might be commonly overriden and by declaring them as built-ins, it might cause a run-time error when running in-fstatic-builtin mode.

Arguments for uncommenting: https://github.com/facebook/hermes/pull/1080

sebholl avatar Aug 05 '23 01:08 sebholl

@tmikov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 07 '23 12:09 facebook-github-bot