facebook
Reduce thread count in ConcurrentHashMapTest to prevent system thread limit breach
The earlier number of threads, 65536, is causing subprocess termination on Apple M3/16 GB/MacOS 15.1. This is understable since the OS thread limit per process is significantly lower(4096 as shown below).
sysctl kern.num_taskthreads
kern.num_taskthreads: 4096
Reducing the thread count to 1024 to add some some margin of error for other platforms as well. 1024 is practically already high enough for most real world use cases so this should be stress enough. But to somewhat compensate for the lower total thread count here, the number of iterations has been increased from 100 to 1000.
Its to be noted that other multi threaded tests in the same file are already using lower total thread counts(e.g. 32 here.
Hi @infomaniac777!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!