folly icon indicating copy to clipboard operation
folly copied to clipboard

fix: fmt workaround for pkg-config generation

Open aminya opened this issue 1 year ago • 3 comments

Workaround for #2250.

Ideally, the code should support the generator expression, but this workaround fixes the problem for fmt.

Also, see https://github.com/fmtlib/fmt/pull/4159 and https://github.com/microsoft/vcpkg/pull/40944

aminya avatar Sep 16 '24 20:09 aminya

Hi @aminya!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 16 '24 20:09 facebook-github-bot

CLA signed @facebook-github-bot

aminya avatar Sep 16 '24 21:09 aminya

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 16 '24 23:09 facebook-github-bot

@Orvid merged this pull request in facebook/folly@1cc9a3aeb8099104ba0297601d3e56b6e61e2f96.

facebook-github-bot avatar Sep 30 '24 19:09 facebook-github-bot