folly icon indicating copy to clipboard operation
folly copied to clipboard

complainUnlessNothrowMoveAndDestroy template deprecated warning when compiling on ubuntu 21.10 with clang++-13

Open RavikumarTulugu opened this issue 4 years ago • 1 comments

I am seeing below warnings when trying to use the proxygen library in my application, i am not sure what are the repercussions of ignoring below warning. Please advise.

proxygen/_build/deps/include/folly/container/detail/F14Policy.h:1231:5: warning: 'complainUnlessNothrowMoveAndDestroy' is deprecated: mark {key_type,mapped_type} {move constructor,destructor} noexcept, or use F14Node* if they aren't [-Wdeprecated-declarations] complainUnlessNothrowMoveAndDestroy<lift_unit_t<MappedTypeOrVoid>>(); ^ proxygen/_build/deps/include/folly/container/detail/F14Policy.h:1356:7: note: in instantiation of member function 'folly::f14::detail::VectorContainerPolicy<unsigned long, quic::QuicStreamState, void, void, void, std::integral_constant<bool, true>>::transfer' requested here transfer(a, std::addressof(before[0]), std::addressof(after[0]), size); ^ proxygen/_build/deps/include/folly/container/detail/F14Table.h:1797:28: note: in instantiation of member function 'folly::f14::detail::VectorContainerPolicy<unsigned long, quic::QuicStreamState, void, void, void, std::integral_constant<bool, true>>::beforeRehash' requested here auto undoState = this->beforeRehash( ^ proxygen/_build/deps/include/folly/container/detail/F14Table.h:1931:5: note: in instantiation of member function 'folly::f14::detail::F14Table<folly::f14::detail::VectorContainerPolicy<unsigned long, quic::QuicStreamState, void, void, void, std::integral_constant<bool, true>>>::rehashImpl' requested here rehashImpl(size(), cc, ss, cc, ss); ^ proxygen/_build/deps/include/folly/container/detail/F14Table.h:1947:7: note: in instantiation of member function 'folly::f14::detail::F14Table<folly::f14::detail::VectorContainerPolicy<unsigned long, quic::QuicStreamState, void, void, void, std::integral_constant<bool, true>>>::debugModeSpuriousRehash' requested here debugModeSpuriousRehash(); ^ proxygen/_build/deps/include/folly/container/detail/F14Table.h:2008:5: note: in instantiation of member function 'folly::f14::detail::F14Table<folly::f14::detail::VectorContainerPolicy<unsigned long, quic::QuicStreamState, void, void, void, std::integral_constant<bool, true>>>::debugModeBeforeInsert' requested here debugModeBeforeInsert(); ^ proxygen/build/deps/include/folly/container/F14Map.h:408:29: note: in instantiation of function template specialization 'folly::f14::detail::F14Table<folly::f14::detail::VectorContainerPolicy<unsigned long, quic::QuicStreamState, void, void, void, std::integral_constant<bool, true>>>::tryEmplaceValue<unsigned long, const std::piecewise_construct_t &, std::tuple<const unsigned long &>, std::tuple<quic::QuicConnectionStateBase &, quic::QuicStreamState &&>>' requested here return table.tryEmplaceValue( ^ proxygen/build/deps/include/quic/state/QuicStreamManager.h:137:16: note: in instantiation of function template specialization 'folly::f14::detail::F14BasicMap<folly::f14::detail::VectorContainerPolicy<unsigned long, quic::QuicStreamState, void, void, void, std::integral_constant<bool, true>>>::emplace<const std::piecewise_construct_t &, std::tuple<const unsigned long &>, std::tuple<quic::QuicConnectionStateBase &, quic::QuicStreamState &&>>' requested here streams.emplace( ^ proxygen/_build/deps/include/folly/container/detail/F14Policy.h:1227:7: note: 'complainUnlessNothrowMoveAndDestroy' has been explicitly marked deprecated here complainUnlessNothrowMoveAndDestroy() {} ^ proxygen/_build/deps/include/folly/container/detail/F14Policy.h:1231:5: warning: 'complainUnlessNothrowMoveAndDestroyquic::QuicStreamState' is deprecated: mark {key_type,mapped_type} {move constructor,destructor} noexcept, or use F14Node* if they aren't [-Wdeprecated-declarations] complainUnlessNothrowMoveAndDestroy<lift_unit_t<MappedTypeOrVoid>>(); ^ proxygen/_build/deps/include/folly/container/detail/F14Policy.h:1224:5: note: 'complainUnlessNothrowMoveAndDestroyquic::QuicStreamState' has been explicitly marked deprecated here [[deprecated( ^

RavikumarTulugu avatar Nov 02 '21 15:11 RavikumarTulugu

I solved it by patching mvsft source code.

图片

hcoona avatar Apr 28 '22 04:04 hcoona