folly icon indicating copy to clipboard operation
folly copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Fixing usage of FOLLY_SANITIZE_ADDRESS in folly/fibers and include experimental/exception_tracer in library

Open yashNaN opened this issue 4 years ago • 2 comments

FOLLY_SANITIZE_ADDRESS is used invalidly in these cases. This is causing ASAN build failures when using the library if the library is build without ASAN but the program using it is built with ASAN. Instead these should be calls to FOLLY_LIBRARY_SANITIZE_ADDRESS.

yashNaN avatar Dec 30 '20 19:12 yashNaN

@yfeldblum Is this PR ready to be merged? I encountered the same problem when depending on folly as a prebuilt library.

dutor avatar Mar 15 '21 05:03 dutor

This is a bit tricky since builds fail with this PR based on things being inconsistently guarded.

yfeldblum avatar Mar 19 '21 08:03 yfeldblum