flux icon indicating copy to clipboard operation
flux copied to clipboard

Published 20 hours ago • verified publisher icon facebook

FluxContainer: Unsafe lifecycle methods were found within a strict-mode tree

Open satoshi-izawa opened this issue 6 years ago • 3 comments

FluxContainer contains componentWillReceiveProps. Does flux fix this problem?

satoshi-izawa avatar May 08 '18 05:05 satoshi-izawa

I would say that this needs to be part of a big discussion as this problem can be fixed as part of a bigger change, adding support to React 16.4

screen shot 2018-05-25 at 5 44 12 pm
  • https://github.com/reactjs/rfcs/blob/master/text/0006-static-lifecycle-methods.md#state-derived-from-propsstate
  • https://reactjs.org/blog/2018/05/23/react-v-16-4.html
  • https://github.com/reactjs/rfcs/pull/6

tiarebalbi avatar May 25 '18 16:05 tiarebalbi

This will likely be addressed at some point within our version of FluxContainer at Facebook, but I do not know when that will be. At that time I can do a release with the appropriate changes, or if someone would like to contribute a PR sooner I'm happy to review!

kyldvs avatar May 26 '18 01:05 kyldvs

I'm reviewing the changes that are going to be required once I have the items I will raise an early PR for a review! Thanks.

tiarebalbi avatar May 26 '18 11:05 tiarebalbi