flow icon indicating copy to clipboard operation
flow copied to clipboard

fix: add missing ocaml includes for flow-parser-bin

Open lxe opened this issue 6 years ago • 5 comments

flow-parser-bin requires opam and ocaml static libs to be installed, from what I gather. Maybe it requires a dynamic lib instead, but I was unable to find it for osx. Suggestions welcome!

lxe avatar Feb 04 '19 18:02 lxe

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 04 '19 18:02 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Feb 04 '19 18:02 facebook-github-bot

I think @mroch is the most familiar with this

nmote avatar Feb 05 '19 00:02 nmote

nice, thanks. how did you run into this? wondering why it built for me and on circle without these changes.

mroch avatar Feb 05 '19 20:02 mroch

@mroch we just built it on os x. Not sure if I'm talking nonsense but maybe it's setup for you on your workstations automatically as an available dynamically linked lib?

vicapow avatar Feb 06 '19 01:02 vicapow