flipper
flipper copied to clipboard
facebook
Bump react-virtualized-auto-sizer and @types/react-virtualized-auto-sizer in /desktop
Summary
This PR implements ES2023 TypedArray.prototype.toReversed method. This is a follow-up of PR https://github.com/facebook/hermes/pull/1286 which added with method on standard Array prototype.
See also:
- PR for
TypedArray.prototype.with: #1365 - PR for
TypedArray.prototype.toSorted: #1367
I am creating separate PRs for each method in case there are any suggestions or change requests from your side, so that PRs are more independent.
Test Plan
Code is annotated with algorithm steps from EcmaScript specification for easier verification and maintenance. I also added tests to verify that methods work as intended. There might be some more edge cases that might be covered based on your experience.
$ echo "new Int8Array([0, 1, 2, 3]).toReversed()" | ./bin/hermes
# >> Int8Array [ 3, 2, 1, 0 ]
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dannysu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@dannysu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
For the other PRs, we should eliminate setOwnIndexed or setToCopyOfTypedArray as well, since we know exactly the the underlying data array and the source/target array buffer have the same type.
Sure thing! I just wanted to make sure that the current approach is correct first. If it is, I can apply it to other methods :)
