flipper
flipper copied to clipboard
facebook
[WIP] Add a way to select Android User to let Flipper working on devices with Work Profile
Summary
Add a way to select Android User to let Flipper working on devices with Work Profile. Fix #953 & #4605
Changelog
Add a setting on settings sheet to select the Android User to use. Useful to select the work profile on devices with two users (personal / work profile)
Comments
I don't know React. It works but help would be appreciate to improve code quality/tests. Please feel free to fix things that are not well written before merging this PR.
Known limitations
- In order to correctly switch from one android user to another, you have to change the setting on the settings sheet and RESTART flipper ("apply and restart").
- You can't save a profile per device. If you select a work profile available on device A, and you wan't to use a personal profile on device B, you have to change manually settings each time you switch devices (and restart flipper, see above).
Hi @sbatezat!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hi there, Any chance someone (@passy ?) review it and merge it on the main branch? I'm sure a lot of people will enjoy this new feature :)
Pull Request Test Coverage Report for Build 4477312510
- 5 of 33 (15.15%) changed or added relevant lines in 2 files are covered.
- 2 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.07%) to 50.941%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx | 4 | 16 | 25.0% |
| desktop/flipper-ui-core/src/chrome/settings/configFields.tsx | 1 | 17 | 5.88% |
| <!-- | Total: | 5 | 33 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| desktop/test-utils/src/pathUtils.tsx | 2 | 57.14% |
| <!-- | Total: | 2 |
| Totals | |
|---|---|
| Change from base Build 4450172237: | -0.07% |
| Covered Lines: | 8180 |
| Relevant Lines: | 14651 |
💛 - Coveralls
Hi @mweststrate , thanks for reviewing my PR 👍
I've answered with some questions, could you please double check them? Please also find bellow some screenshot, as requested:
Hi @mweststrate, could you please have a look on my questions above? Thanks!
Hi @mweststrate, just a quick reminder on this topic :) Could you please answer my questions above?
Sorry, been travelling and still catching up, hopefully next week.
On Thu, Apr 13, 2023 at 9:18 AM Sébastien Batézat @.***> wrote:
Hi @mweststrate https://github.com/mweststrate, just a quick reminder on this topic :) Could you please answer my questions above?
— Reply to this email directly, view it on GitHub https://github.com/facebook/flipper/pull/4606#issuecomment-1506472085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBAVLTQ4TQ2O43VAMH3XA6SDRANCNFSM6AAAAAAV476Z4E . You are receiving this because you were mentioned.Message ID: @.***>
@sbatezat Great effort! Adding work profile support is an excellent feature. @mweststrate Could you please revisit for a review when you get the chance? Thanks.
I've juste resolved conflicts and merged every changes you made @mweststrate could you please have a look on this? My teams are waiting for this for a long time now
Again some conflicts resolved to merge latest updates of the main branch. @mweststrate if you don't have time to review these changes, is it possible to ask to someone else in the team?