flipper icon indicating copy to clipboard operation
flipper copied to clipboard

Add support for Android DataStore (shared preferences replacement)

Open roomedia opened this issue 2 years ago • 4 comments

Summary

  • Add support for DataStore (shared preferences replacement)
    • https://github.com/facebook/flipper/issues/2407

Changelog

  • Create Flipper plug-in that inspects, edits, and deletes androidx.dataStore
    • works with both Preferences and Proto DataStore.

Test Plan

Sample App

  • build, install & start android sample app
  • navigate to datastore test page

Flipper Desktop App

  • start flipper desktop app
  • enable DataStore Viewer plug-in once
  • inspect, edit value by double-click, and delete data by right-click

roomedia avatar Oct 24 '22 09:10 roomedia

Pull Request Test Coverage Report for Build 4308248550

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 51.01%

Totals Coverage Status
Change from base Build 4306603014: 0.02%
Covered Lines: 8165
Relevant Lines: 14608

💛 - Coveralls

coveralls avatar Mar 01 '23 15:03 coveralls

@lblasa has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 03 '23 10:03 facebook-github-bot

Hi @roomedia! Thanks for creating this PR. Changes look good but we are having issues with it when trying to build it with our internal tooling.

Mainly, because of protobuf.

Is this necessary to keep? Could it be removed?

lblasa avatar Mar 08 '23 12:03 lblasa

Hi @roomedia! Thanks for creating this PR. Changes look good but we are having issues with it when trying to build it with our internal tooling.

Mainly, because of protobuf.

Is this necessary to keep? Could it be removed?

Hi @lblasa There are two types of DataStores: Preferences DataStore and Proto DataStore. If you remove Protobuf, you will not be able to support Proto DataStore.

roomedia avatar Mar 11 '23 03:03 roomedia

Thanks for the explanation. I'll try again this week if I have the time :)

lblasa avatar Mar 21 '23 09:03 lblasa

Hey @lblasa, really do not wanna push, but did you find time to look into this? :) Can community help with anything.

JohannesPtaszyk avatar Jul 26 '23 13:07 JohannesPtaszyk

@mweststrate I saw you being active in the ticket related to this. Is there any way, we could get this PR merged?

JohannesPtaszyk avatar Sep 26 '23 18:09 JohannesPtaszyk

@lblasa has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 28 '23 09:09 facebook-github-bot

@lblasa has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 28 '23 09:09 facebook-github-bot