flipper
flipper copied to clipboard
FlipperOkhttpInterceptor making SSE not working
🐛 Bug Report
in the reactNativeFlipper.java, the following lines making EventSource (SSE) not working.
....
NetworkFlipperPlugin networkFlipperPlugin = new NetworkFlipperPlugin();
NetworkingModule.setCustomClientBuilder(
new NetworkingModule.CustomClientBuilder() {
@Override
public void apply(OkHttpClient.Builder builder) {
builder.addNetworkInterceptor(new FlipperOkhttpInterceptor(networkFlipperPlugin));
}
});
Environment
Android, Flipper 0.93, react native 0.64.0
I am not sure if this is a bug or is normal behavior.
we discovered it in the following conversation: https://github.com/facebook/react-native/issues/28835
any news about this ?
@axwell in production mode SSE/EventSource it is working, that networkFlipperPlugin is only applied in development mode, for you can intercept the network calls and show it in Flipper.
We don't really use the OkHttpClient interceptor internally, so if anybody wants to investigate if this could be wired better, PRs are welcome!
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.
I'll like to keep this issue open :) We still have the same problem on our side too.
You're interested in investigating it further? Otherwise there is little value in keeping issues open that no one is willing to invest in.
Yeah, ran into this issue at work today. Works fine on release versions of Android apps, but not debug.
What does this specific snippet of code do? Is it required to use Flipper in normal debugging practices?
Still looking for some insight into this code snippet.
What does this specific snippet of code do? Is it required to use Flipper in normal debugging practices?
Same here. @forkball Did you find any solution?
Same here. @forkball Did you find any solution?
I just commented the snippet in question out for the time being.