flipper icon indicating copy to clipboard operation
flipper copied to clipboard

Discussion: Add support for DataStore (shared preferences replacement)

Open bizzguy opened this issue 3 years ago • 10 comments

Android has introduced a replacement for Shared Preferences called DataStore

 https://developer.android.com/topic/libraries/architecture/datastore

Just asking if there are any plans on the roadmap to create a plugin for DataStore?

bizzguy avatar Jun 02 '21 15:06 bizzguy

Some thoughts. I started looking at the DataStore API and there seem to be some deficiencies in "discovery" of DataStores and in interrogating a DataStore for its preference values and types.

Given that it is still in beta, I don't think I'd actually use DataStore on a production project yet. Here is the history of the library versions:

2021-06-08_11-03-13

I'm going to continue to experiment with it but creating a plugin may be a little premature.

Is anybody (that uses Flipper) actually using DataStore yet?

Also, just thinking ahead. Seems like the current "Shared Preference Viewer" desktop plugin could be the first version of a DataSource Viewer. Thoughts?

Update: Shared Preference Viewer does not use DataTable which might actually be a better UI experience to fix that first.

bizzguy avatar Jun 08 '21 16:06 bizzguy

Thanks for the updates! Yeah agreed that using the same plugin makes sense!

mweststrate avatar Jun 09 '21 08:06 mweststrate

+1 Flipper + DataStore

b95505017 avatar Jun 19 '21 21:06 b95505017

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

stale[bot] avatar Jan 08 '22 22:01 stale[bot]

+1 DataStore support on Flipper

batuypn avatar Mar 13 '22 00:03 batuypn

+1 Flipper + DataStore

furusin avatar Mar 18 '22 03:03 furusin

Flipper is very pluggable, so pull requests welcome! https://fbflipper.com/docs/tutorial/intro/.

Please avoid posting +1's, use thumbs up instead.

mweststrate avatar Mar 18 '22 09:03 mweststrate

Hi there, I just opened Pull Request(https://github.com/facebook/flipper/pull/4243)

Please check it out @mweststrate

roomedia avatar Oct 24 '22 09:10 roomedia

Any plans on merging the opened PR ?

ritesh-singh avatar Feb 09 '23 17:02 ritesh-singh

@mweststrate could we please get the above PR reviewed and merged.

sudansh avatar Mar 01 '23 13:03 sudansh

2024 started. Would be more helpful now.

mwshubham avatar Jan 02 '24 07:01 mwshubham