fbt icon indicating copy to clipboard operation
fbt copied to clipboard

Published 20 hours ago • verified publisher icon facebook

android: upgrade rn-demo-app to RN 0.64.0

Open ecreeth opened this issue 3 years ago • 15 comments

Summary

In 8fdbce6 the dependencies were updated to 0.64.0 but not in the Android native side.

  • [x] update android code to 0.64.0
  • [x] update react-native-fbt to 0.0.5
  • [x] ~~added temporal fix to react-native-fbt. In version 0.0.3 this package has a mistake; its calling a file that doesn't exists in that location. The js directory is not found~~ https://github.com/facebook/fbt/blob/73468ad4ab6a2a754d739d98dd7ef1246619b9ee/packages/react-native-fbt/package.json#L6

Now the application build successfully

1 1

The react-native-fbt package needs to be updated to 0.0.3. In new versions of React Native the TurboModuleRegistry is found in another destination, so the application will not compile. https://github.com/facebook/fbt/blob/893492c5bb9349be532113741f8bb7c81aa473b0/packages/react-native-fbt/index.js#L22

This is resolved in 0.0.3 https://github.com/facebook/fbt/blob/893492c5bb9349be532113741f8bb7c81aa473b0/packages/react-native-fbt/NativeFbtModule.js#L27

Test plan

yarn android

ecreeth avatar May 26 '21 14:05 ecreeth

cc @hramos

ecreeth avatar May 26 '21 15:05 ecreeth

@jrwats has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 26 '21 23:05 facebook-github-bot

@ecreeth has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 27 '21 14:05 facebook-github-bot

I just update the react-native-fbt to 0.0.3 and added a temporal fix to it. Everything is OK now. I'll send another PR to fix that issue.

ecreeth avatar May 27 '21 14:05 ecreeth

@ecreeth has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Jun 18 '21 13:06 facebook-github-bot

@kayhadrin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 21 '21 20:06 facebook-github-bot

@hramos bump version to 0.0.4 but is not published in npm yet. We need to use version 0.0.4 to build successful

ecreeth avatar Jun 22 '21 14:06 ecreeth

@hramos bump version to 0.0.4 but is not published in npm yet. We need to use version 0.0.4 to build successful

0.0.5 is published as of last week, heads up.

jrwats avatar Aug 06 '21 14:08 jrwats

@ecreeth has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 06 '21 14:08 facebook-github-bot

@ecreeth has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Aug 06 '21 14:08 facebook-github-bot

@jrwats is done!

ecreeth avatar Aug 06 '21 14:08 ecreeth

@kayhadrin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 12 '21 07:08 facebook-github-bot

@kayhadrin What's failing? Can I solve the problem or is it an internal-related issue?

ecreeth avatar Aug 12 '21 11:08 ecreeth

More easily maintain RN updates by using react-native-test-app

Here is a video of how it works in Microsoft https://www.youtube.com/watch?v=DAEnPV78rQc

retyui avatar Nov 11 '21 19:11 retyui

@kayhadrin What's failing? Can I solve the problem or is it an internal-related issue?

Sorry it's been a while since this PR was submitted and it's getting rebase conflicts. It'd be great to know if it's still needed nowadays. cc: @hramos

kayhadrin avatar Nov 24 '21 00:11 kayhadrin