facebook360_dep icon indicating copy to clipboard operation
facebook360_dep copied to clipboard

Get year method footer update

Open DesmondSanctity opened this issue 4 years ago • 1 comments

Summary

The motivation for this change made is to ensure accuracy and correctness of information. The footer copywright year reads 2019 and so need to be updated to current year. So I re-wrote the JavaScript method.

Changelog

[Fixes] [bug] - Updated getYear() method

Test Plan

Below is a short video showing the before and after of the User Interface of the current year method facebook360_depngetYear method updated.zip

DesmondSanctity avatar Aug 09 '20 17:08 DesmondSanctity

Hi @DesmondSanctity! The way you're getting the year information seems to be the same as the current method:

var date = new Date();
currentYear = date.getFullYear();
...
copyright: `Copyright © ${currentYear} Facebook Inc.`

versus the current

copyright: `Copyright © ${new Date().getFullYear()} Facebook Inc.`

I agree though that when I load the page it says 2019 at the bottom, so it might have been a bad push on our end. I'll check that.

aparrapo avatar Aug 31 '20 15:08 aparrapo