facebook-sdk-for-unity icon indicating copy to clipboard operation
facebook-sdk-for-unity copied to clipboard

Feature Request: Support App Privacy Manifest

Open keitanxkeitan opened this issue 6 months ago • 28 comments

Checklist

  • [x] I've updated to the latest released version of the SDK
  • [x] I've searched for existing feature requests on GitHub issues
  • [x] I've read the Code of Conduct
  • [x] I've given my issue the title: Feature Request: [name of my feature request]

Goals

Apple required App Privacy manifests until 2025. So Facebook SDK that contains an app privacy manifest must be signed. I would like to know when you adopt this change.

References https://developer.apple.com/videos/play/wwdc2023/10060/ https://developer.apple.com/news/?id=av1nevon https://developer.apple.com/app-store/user-privacy-and-data-use/

Please check it out. Thanks!

Expected Results

Add Privacy Manifest

Code Samples & Details

No response

keitanxkeitan avatar Jan 10 '24 14:01 keitanxkeitan

Any update on this?

gtalwadkar avatar Jan 17 '24 07:01 gtalwadkar

Is there an ETA on this?

cberkeleyHutch avatar Jan 31 '24 16:01 cberkeleyHutch

Hi guys, is there any updates?

BogdanBobkov avatar Mar 18 '24 12:03 BogdanBobkov

Guys, any update on this?

https://developer.apple.com/news/?id=3d8a9yyh - Apple released information about dates, it is required already on May 1, 2024 https://developer.apple.com/support/third-party-SDK-requirements/ - FB SDK is in the list of SDKs that are required to have privacy manifest

Viabo avatar Mar 26 '24 16:03 Viabo

@facebook-github-bot - any updates on it? this is crucial for many developers now

shmuelvpapaya avatar Mar 31 '24 10:03 shmuelvpapaya

Facebook SDK v17.0.0 is released. Do you have some news?

SergeyChereshnyuk avatar Apr 02 '24 12:04 SergeyChereshnyuk

Joining this thread - Would love an update if anyone has some new info.

EmmetBeachBum avatar Apr 04 '24 12:04 EmmetBeachBum

any news ? last facebook unity sdk is 16.0.2 that is Aug 31, 2023

psstevenchan avatar Apr 05 '24 09:04 psstevenchan

for unity you can try change pods dependencies on v17.0.0 for iOS target

arturkorzh avatar Apr 05 '24 10:04 arturkorzh

for unity you can try change pods dependencies on v17.0.0 for iOS target

CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (= 17.0.0)

or

[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (~> 17.0)

lurenzhangdeshuai avatar Apr 09 '24 02:04 lurenzhangdeshuai

any news ? last facebook unity sdk is 16.0.2 that is Aug 31, 2023

lurenzhangdeshuai avatar Apr 09 '24 02:04 lurenzhangdeshuai

Any updates?

supergardener avatar Apr 09 '24 07:04 supergardener

Any updates?

CSystem avatar Apr 12 '24 07:04 CSystem

for unity you can try change pods dependencies on v17.0.0 for iOS target

CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (= 17.0.0)

or

[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (~> 17.0)

i mean dependency.xml in plugin folder like version="~> 17.0.0"

arturkorzh avatar Apr 12 '24 07:04 arturkorzh

for unity you can try change pods dependencies on v17.0.0 for iOS target

CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (= 17.0.0) or [!] CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (~> 17.0)

i mean dependency.xml in plugin folder like version="~> 17.0.0"

[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (~> 17.0.0)

None of your spec sources contain a spec satisfying the dependency: FBSDKShareKit (~> 17.0.0). T T

lurenzhangdeshuai avatar Apr 12 '24 08:04 lurenzhangdeshuai

Any updates on this? The clock is ticking and we are not that far away from the deadline set on May 1, 2024. We just have 2 weeks before the time is up, and then any submission on the App Store of our Unity applications will require us to have a compliant Facebook Unity SDK. Facebook, could you give us an ETA on this, please?

D117 avatar Apr 12 '24 12:04 D117

+1

daltonbr avatar Apr 12 '24 14:04 daltonbr

Is there an ETA on this? Otherwise we all need to remove the Facebook SDK for Unity from the games in order to be able to ship updated in 2 weeks.

jnbt avatar Apr 12 '24 15:04 jnbt

We are a gaming company which depends on it. An ETA or at least a message like "we don't do it" would be appreciated, so we can plan our own upgrades accorddinly.

esigma5 avatar Apr 12 '24 15:04 esigma5

Has anyone tried directly changing the ios-sdk version of CocoaPods to 17.0.0? I've attempted to use facebook-unity-sdk 16.0.2 and change the ios-sdk version from 16.0.2 to 17.0.0 directly in the dependency.xml, and successfully built the app. However, I'm unsure if running it this way might lead to unexpected errors. Has anyone else tried this?

sddd1234567 avatar Apr 15 '24 05:04 sddd1234567

Has anyone tried directly changing the ios-sdk version of CocoaPods to 17.0.0? I've attempted to use facebook-unity-sdk 16.0.2 and change the ios-sdk version from 16.0.2 to 17.0.0 directly in the dependency.xml, and successfully built the app. However, I'm unsure if running it this way might lead to unexpected errors. Has anyone else tried this?

I've tried but failed

lurenzhangdeshuai avatar Apr 15 '24 08:04 lurenzhangdeshuai

To all who are looking for it: Yesterday Facebook released an update of the Unity SDK, which claims to address the "privacy manifest".

https://developers.facebook.com/docs/unity/change-log

(Note: I have not yet tested it myself)

jnbt avatar Apr 18 '24 14:04 jnbt

Hi, I'm using Unity 2021.3.37 LTS and Facebook 17.0.0 Once I build the iOS I get this file Screenshot 2024-04-21 at 5 05 54 PM

After importing the new Facebook SDK I also got the same, Do I miss something, or is importing the SDK fixing this issue? Screenshot 2024-04-21 at 5 05 54 PM

Moayad-Rahhal avatar Apr 21 '24 14:04 Moayad-Rahhal

I updated Unity to version 2022.3.22, firebase, fbm to 10.22.0 and facebook to version 17.0.0 I see that UnityFramework and all SDKs except Facebook have registered private manifests.

I also see the same errors when uploading to the app store.

I have been working with Facebook SDK for a long time and quite often they release crooked updates when I had to roll back versions or finish something manually, so there are suspicions that they again did not foresee something.

If I'm wrong, please tell me someone that everything is fine with you or tell me what I can do about my side?

Thank you image (15) image (16)

UP: By the way, if someone is unable to build with a similar error: ld: Assertion failed: (false && "compact unwind compressed function offset doesn't fit in 24 bits"), function operator(), file Layout.cpp, line 5758. add this to the postbuild (It helped me to):

string projectPath = PBXProject.GetPBXProjectPath(path);
PBXProject project = new PBXProject();
project.ReadFromFile(projectPath);

// Unity Framework: Add `-ld_classic` to "Other Linker Flags".
var targetUnityFramework = project.GetUnityFrameworkTargetGuid();
project.AddBuildProperty(targetUnityFramework, "OTHER_LDFLAGS", "-ld_classic");

AvenNight avatar Apr 26 '24 04:04 AvenNight

Hi all,

Pointing out that the Privacy Manifests appear to have been added, but not in a way that would result in them being merged into the UnityFramework's privacy manifest (which would explain why it's not being found in the screenshots posted by others above).

My assumption (unconfirmed - haven't researched / submitted to App Store yet) is that the privacy manifests of ALL frameworks (not just the UnityFramework) are considered for apps, so things should be good now.

However, @AvenNight 's post just above may suggest otherwise 🤔

Before/after comparison:

v16.0 FBSDKCoreKit.Framework content: image

v17.0.1 FBSDKCodeKit.Framework content: image

bilalakil avatar May 02 '24 04:05 bilalakil

@bilalakil hmm, it’s very strange that your Pods version is FBSDKCodeKit 17.0.1, while mine is 17.0.0 without PrivacyInfo FBSDKCodeKit.Framework content: image

I took the Unity SDK from here: https://developers.facebook.com/docs/unity/change-log#facebook-sdk-for-unity-changelog

Do you have any ideas what could be wrong?

AvenNight avatar May 03 '24 09:05 AvenNight

i manually change version 17.0.1 (I also updated the Pods etc.) image

in the end it helped and PrivacyInfo.xcprivacy appeared: image

Now let's try to upload this to the app store! I'll keep posted (:

AvenNight avatar May 07 '24 10:05 AvenNight

Our app was approved and released with 17.0.1.

bilalakil avatar May 07 '24 22:05 bilalakil