`bug` Fixed Build Issue and upload path for IOS
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign contributor license agreement
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
- [x] I've added the proper label to this pull request (e.g.
bugfor bug fixes)
Pull Request Details
- I removed the method "IOSFBUpdateUserProperties" Since it caused issues when trying to build in xcode, since that method no longer existed on the IOS plugin.
- I changed the path for uploading images and videos from AbsolutePath to LocalPath. This was necessary because on a real device, the image could not be loaded from the AbsolutePath path. Changing this to LocalPath fixed the issue. Especially if it was an image saved from unity to that path.
Describe what you accomplished in this pull request (for example, what happens before the change, and after the change)
Test Plan
Test Plan:
- Build Plugin
- Implement in Unity Project.
- Make IOS build
- Make sure it is successful
- Trying to using the facbook gaming services to share an image screenshot from unity.
Hi @eomene!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Please merge this PR. Your master branch doesn't work on iOS without that fix. BTW, you can make an integration tests for your SDK, it's 2022 year now.