facebook-ruby-business-sdk
facebook-ruby-business-sdk copied to clipboard
Support version 5 of the countries gem
It drops support for Ruby <2.7, as those are EOL: https://github.com/countries/countries/blob/9046bc79298986554f01ce6363c9310b1081a8f4/CHANGELOG.md#500-20220403-1744-0000
Otherwise this library only uses ISO3166::Country.search, which still works in a compatible way:
https://github.com/facebook/facebook-ruby-business-sdk/blob/f2e6f54084ee50c16acbb31410acd60aa5c44fda/lib/facebook_ads/ad_objects/server_side/util.rb#L137
Removed from add_development_dependency because I don't see it being used in dev, and AFAIK if it's in the regular dependencies, we don't need to repeat it in the development dependencies anyway.
Did not update Gemfile.lock since it doesn't appear to be kept up to date.
To use this fork until/if it's merged:
gem "facebookbusiness", github: "barsoom/facebook-ruby-business-sdk", branch: "support-countries-5"
@alanho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
thanks for the PR @henrik . looks good to me, we will merge this.
@alanho merged this pull request in facebook/facebook-ruby-business-sdk@56588d4e4d02d1b1e9856a8de41b1670ca1ec8ed.