facebook-python-business-sdk icon indicating copy to clipboard operation
facebook-python-business-sdk copied to clipboard

Fix lookalike_spec type

Open james10424 opened this issue 2 years ago • 2 comments

Currently, the lookalike_spec has a type of string, which will give the following warning.

UserWarning: value of lookalike_spec might not be compatible.  Expect string;  got <class 'dict'>
    warnings.warn(message)

However, this is incorrect. The documentation says lookalike_spec is a type type: array, which means it's a dictionary in Python. Changing string to map dismisses the warning.

james10424 avatar Sep 15 '21 14:09 james10424

Hi @james10424!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 15 '21 14:09 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Sep 15 '21 14:09 facebook-github-bot