facebook-python-business-sdk icon indicating copy to clipboard operation
facebook-python-business-sdk copied to clipboard

Added AdAccount -> create_agency, get_agencies, create_user_permissio…

Open advance512 opened this issue 7 years ago • 5 comments

…n, get_user_permissions

Added Business -> get_agencies, get_user_permissions, get_user_permission

Basically, various missing API calls.

advance512 avatar Apr 30 '17 13:04 advance512

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

facebook-github-bot avatar Apr 30 '17 13:04 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Apr 30 '17 13:04 facebook-github-bot

Additions to PR:

Prevented warnings in get_user_permission when getting BM people (or business personas) with explicit fields Added get_businesses to User to allow getting all accessible BMs Added get_extended_access_token to User to allow getting an extended access token

advance512 avatar Jun 20 '17 22:06 advance512

Should I resolve the conflicts and can we merge this in?

advance512 avatar Feb 01 '18 19:02 advance512

Hi @advance512 - Most of the files you've changed are autogenerated, so they need to be fixed in Facebook's internal code generation tool and they won't accept PRs for them.

brandonkane avatar Feb 01 '18 21:02 brandonkane