facebook-php-business-sdk
facebook-php-business-sdk copied to clipboard
facebook
Fix namespace
Hi @minterior!
Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.
In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
Sure!
That class is raising deprecation notices in composer install and potentially it could not be loaded/found in the expected path:
Generating optimized autoload files
Deprecation Notice: Class FacebookAds\Object\Agency located in ./vendor/facebook/php-business-sdk/src/FacebookAds/Object/Fields/Agency.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201
Why is this still not merged? I'm having the same issue, will this be in the next version release?
Composer 2.0.0 RC1 was released today https://github.com/composer/composer/releases/tag/2.0.0-RC1, so getting close to the stable release. When will this PR be merged & tagged?
