facebook-php-business-sdk
facebook-php-business-sdk copied to clipboard
facebook
Fixes the bug where the LOOKALIKE_VALUE schema field was getting hashed even when $is_hashed = false in the addUsers method of CustomAudienceMultiKey
See https://developers.facebook.com/bugs/565178463606247 for the original report and steps to reproduce.
In a separate commit, I also made a small edit to test/FacebookAdsTest/ApiTest.php, mocking getRequestParameters as empty array.
I am unfamiliar with test/FacebookAdsTest/ApiTest.php and the class that it's testing and am not positive that this commit makes sense, but it seems reasonable to me.
I'm surprised someone left the tests failing.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
By the way, one of my commits (included in this pull request) fixes the unit tests (at least locally, and assuming my edits make sense).
So that would help with the build failing: https://github.com/facebook/facebook-php-ads-sdk/issues/340
@duliomatos Hi, I've never submitted a pull request before and don't know what to expect. Who is in charge of the "facebook-php-ads-sdk" repo, and when should I expect this request to be reviewed and merged in, and how often are there new "releases"?
I use "facebook-php-ads-sdk" every day and appreciate it and I'm very excited to start contributing! Thanks so much!
@xiaotchen and @pruno Hi, I've never submitted a pull request before and don't know what to expect. Who is in charge of the "facebook-php-ads-sdk" repo, and when should I expect this request to be reviewed and merged in, and how often are there new "releases"?
I use "facebook-php-ads-sdk" every day and appreciate it and I'm very excited to start contributing! Thanks so much!
Hi @xiaotchen , I see that you approved and merged a recent pull request, but not this older one from me. I'm new to this and am wondering what I can do to help make it easy for one of you to review this and merge it in. I'd love to help keep this SDK in top shape. Thanks!
Hi @cloudxu and @xiaotchen , I'm wondering if you'd please consider merging my pull request or at least providing feedback about how I could have submitted it differently.
It would mean a lot to me.
I submitted it more than 2 months ago to fix a bug in the existing Facebook SDK.
I'm trying to help (and I'll personally use the code too once it's approved).
Thanks!
@windsfantasy6 and @saikikwok Can you please review and merge this pull request? It's super basic. Let me know if there is anything I can do to help. Thanks.
Maybe https://github.com/facebook/facebook-php-business-sdk/commit/22c8eefe2c7e3766ad49c925e9a473a2bea8ab9a#diff-469150db08bcdc9723d714f7e6b63b9a fixed this bug even though everyone has been ignoring this pull request and my original bug report.