facebook-php-business-sdk icon indicating copy to clipboard operation
facebook-php-business-sdk copied to clipboard

Fixed bug in the response header's parser

Open SantyagoSeaman opened this issue 9 years ago • 6 comments

There was incorrect string slicing in case if header's value has symbol ":". For example header X-FB-Ads-Insights-Throttle: { "app_id_util_pct": 100, "acc_id_util_pct": 10 }

SantyagoSeaman avatar Aug 02 '16 22:08 SantyagoSeaman

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

ghost avatar Aug 02 '16 22:08 ghost

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ghost avatar Aug 03 '16 00:08 ghost

Can we get this merged in. This is such a simple fix but not having such an important change is making managing the throttle near impossible without writing our own libraries.

brenjt avatar Feb 06 '17 22:02 brenjt

Hi guys! Will this fix ever be merged ?

kickiss avatar Apr 28 '17 08:04 kickiss

Seems like nobody follows this up?

bartclaeys avatar Jun 08 '17 18:06 bartclaeys

FWIW there's a fix for this in master

jimrubenstein avatar Oct 07 '17 02:10 jimrubenstein