facebook-java-business-sdk icon indicating copy to clipboard operation
facebook-java-business-sdk copied to clipboard

Fixed NPE on delete users from custom audience in Facebook Java SDK

Open vijendranr opened this issue 5 years ago • 7 comments

#328 Delete of more than 150 or 200 users from custom audience is failing with NPE.

The changes as part of PR is tested with 10000 users delete from custom audience and its working fine.

vijendranr avatar Dec 21 '20 17:12 vijendranr

Hi @vijendranr!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 21 '20 17:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Dec 21 '20 18:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Dec 22 '20 16:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Dec 22 '20 17:12 facebook-github-bot

@donglinw-fb can we get these changes in? running into the same issue

dphan72 avatar Feb 04 '22 22:02 dphan72

Same here.

@vijendranr I think most of the code from this repo is generated from https://github.com/facebook/facebook-business-sdk-codegen. It might be worth opening a PR there. If you don't have time, I'm happy to do that.

dimamo5 avatar Jun 08 '22 16:06 dimamo5

@dimamo5 : You can proceed and check if this is fixed in latest code, I totally forgot about this PR. And i don't have that corporate git hub account @vijendranr now. You can create new PR if needed.

vijendrabhat avatar Jan 10 '23 12:01 vijendrabhat