facebook-ios-sdk icon indicating copy to clipboard operation
facebook-ios-sdk copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Fix infinite recursion when enabling `.graphAPIDebugInfo` logging behavior

Open revolter opened this issue 2 years ago • 2 comments
trafficstars

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • [x] sign contributor license agreement
  • [x] I've ensured that all existing tests pass and added tests (when/where necessary)
  • [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • [ ] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

revolter avatar Aug 15 '23 07:08 revolter

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • [x] sign contributor license agreement
  • [ ] I've ensured that all existing tests pass and added tests (when/where necessary)
  • [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • [ ] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • [x] sign contributor license agreement
  • [ ] I've ensured that all existing tests pass and added tests (when/where necessary)
  • [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • [ ] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #2152.

Test Plan

romarealmreborn avatar Oct 12 '23 05:10 romarealmreborn

ผู้

romarealmreborn avatar Oct 28 '23 07:10 romarealmreborn

Any chance this PR is getting some attention?

There is a small and easy to understand fix that fixes an actual production crash.

The community gave it to you. For free.

thisisthekap avatar Jan 23 '24 06:01 thisisthekap

I fixed the conflict

revolter avatar Jan 30 '24 10:01 revolter

@jjiang10, please reopen and merge this 🙏🏻

revolter avatar Jun 01 '24 06:06 revolter

Any update on this?

erdemgonul avatar Jun 17 '24 09:06 erdemgonul

Seems like Meta hosts projects on GitHub, but does not care a bit about community contributions. Even if they are served to them on a silver platter.

thisisthekap avatar Jun 17 '24 16:06 thisisthekap

Seems like Meta hosts projects on GitHub, but does not care a bit about community contributions. Even if they are served to them on a silver platter.

We are very sorry about this. Since the editing on this codebase is going through the internal code review system, the committers are not directly looped in PRs/Issues. I will check with the team who own this part.

Zhiyi-Zhang avatar Jul 10 '24 17:07 Zhiyi-Zhang

@Zhiyi-Zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 10 '24 17:07 facebook-github-bot

@Zhiyi-Zhang merged this pull request in facebook/facebook-ios-sdk@e905cac2d4eb6e40ce4fec8c0f6bc103bd647995.

facebook-github-bot avatar Jul 10 '24 18:07 facebook-github-bot