facebook-ios-sdk icon indicating copy to clipboard operation
facebook-ios-sdk copied to clipboard

FBSDKCoreKit.framework: Unsealed contents present in the root directory of an embedded framework

Open bdaz opened this issue 2 years ago • 5 comments

Checklist before submitting a bug report

Xcode version

14.0

Facebook iOS SDK version

14.1.0

Dependency Manager

CocoaPods

SDK Framework

Core

Goals

The directory structure of FBSDKCoreKit.framework is invalid for an embedded framework, because FacebookSDKStrings.bundle is in the wrong place. This prevents macCatalyst builds when the app includes FBSDKCoreKit, because code signing will fail.

Simply moving FBSDKCoreKit/XCFrameworks/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/FBSDKCoreKit.framework/FacebookSDKStrings.bundle to FBSDKCoreKit/XCFrameworks/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/FBSDKCoreKit.framework/Versions/A/Resources/FacebookSDKStrings.bundle fixes this issue.

Expected results

You should be able to codesign the FBSDKCoreKit framework for macCatalyst without issue.

Actual results

/usr/bin/codesign --force --sign <abc>  --preserve-metadata=identifier,entitlements '/Users/bdaz/Library/Developer/Xcode/DerivedData/Thoughtful-cbuhkdrltepatyaqufbenzszbwvr/Build/Products/Debug-maccatalyst/Thoughtful.app/Contents/Frameworks/FBSDKCoreKit.framework'

/Users/bdaz/Library/Developer/Xcode/DerivedData/Thoughtful-cbuhkdrltepatyaqufbenzszbwvr/Build/Products/Debug-maccatalyst/Thoughtful.app/Contents/Frameworks/FBSDKCoreKit.framework: unsealed contents present in the root directory of an embedded framework

Steps to reproduce

  1. Add FBSDKCoreKit as a dependency. In my case, I'm using Cocoapods.
  2. Try to build your app for macCatalyst.

Code samples & details

No response

bdaz avatar Oct 13 '22 19:10 bdaz

This is still an issue, FYI! Really easy fix for you guys.

bdaz avatar Dec 29 '22 02:12 bdaz

Thanks, it worked

kesha-antonov avatar Apr 08 '23 12:04 kesha-antonov

Please update the lib !

boblepepeur avatar Sep 19 '23 19:09 boblepepeur

Wow! Can't believe this issue has been open for such long!!! Thanks for the workaround

arshiacont avatar Feb 10 '24 22:02 arshiacont

Still an issue. The workaround works.

andytriboletti avatar Mar 10 '24 00:03 andytriboletti