facebook-ios-sdk icon indicating copy to clipboard operation
facebook-ios-sdk copied to clipboard

Feature Request: Dismiss ShareDialog after a content has been shared

Open Knapiii opened this issue 2 years ago • 14 comments

Checklist before submitting a feature request

Goals

After a content is shared with Facebook, the share pop up view will be dismissed

Expected results

Dismiss the ShareDialog after the content has been shared with Facebook

Code samples & details

// INSERT YOUR CODE HERE
let content = ShareLinkContent()
let showDialog = ShareDialog(viewController: presenter, content: content, delegate: self)
if (showDialog.canShow) {
   showDialog.show()
}

Knapiii avatar Sep 05 '22 09:09 Knapiii

I have the same issue in iOS 15/16 on any of my iDevices for my Obj-C project. After sharing to Facebook with FBSDKShareDialogModeShareSheet the "Shared to Facebook!" confirmation shows but there is no way to dismiss. Also, delegates never get called for success (even though I see post to my Facebook test account). Please remedy; I don't know how everyone isn't complaining about this as it cripples the app so nothing else can be done!

This should be classified as a bug not an enhancement correct? Also happens with sample swift project from this repo.

ALSO, if you start share workflow, so that share sheet shows at bottom, but decide to cancel you can't cancel or dismiss share sheet. You're stuck having to select a Share to option which this gets you stuck at end of workflow as stated above. PLEASE PLEASE FIX!

IMG_FE6EB18949B5-1

kross51 avatar Sep 07 '22 05:09 kross51

tried Facebook-sdk 14.0.0 14.0.1 Xcode version 13.4.1 14.0

I had the same problem

I hope after a content is shared with Facebook, the share pop up view will be dismissed

workflow share sheet shows at bottom,but you can't cancel or dismiss share sheet.

FBSDKSharePhoto * sharePhoto = [[FBSDKSharePhoto alloc] initWithImage:uiImage isUserGenerated:YES];
    
FBSDKSharePhotoContent* content = [[FBSDKSharePhotoContent alloc] init];
content.photos = @[sharePhoto];
        
[FBSDKShareDialog showFromViewController:[IZLAuthon currentViewController] withContent:content delegate:self];

WechatIMG134

vigacc avatar Sep 07 '22 06:09 vigacc

same issue with device installed lastest facebook app (382), installed facebook app (247) is no bug using 14.1.0 version SDK

QIYA0130 avatar Sep 07 '22 07:09 QIYA0130

我也遇到了这样的问题,

Rycccccccc avatar Sep 07 '22 08:09 Rycccccccc

I have the same issue。

yingguqing avatar Sep 07 '22 09:09 yingguqing

+1

lixiang1994 avatar Sep 08 '22 03:09 lixiang1994

I did some hypotheses on this, I think it is a bug related to the Facebook App. Details are mentioned on #2114

ArsalImam avatar Sep 08 '22 09:09 ArsalImam

+1

Please send this issue to Facebook App development team ASAP. It's making our app stuck often and impacting user expriences bad.

mhchoi-bagelcode avatar Sep 08 '22 14:09 mhchoi-bagelcode

+1

Forrest-Ripl avatar Sep 08 '22 20:09 Forrest-Ripl

I have the same issue

pratik-softgames avatar Sep 09 '22 09:09 pratik-softgames

Any update facing the same issue.

ankitpunchh avatar Sep 11 '22 10:09 ankitpunchh

Same here, delegate is never being called after using DialogMode shareSheet it just works when using native mode.

I can' even dismiss the SLComposeViewController created by the SDK, it blocks our App once displayed.

Polenoso avatar Sep 12 '22 13:09 Polenoso

The issue is in Facebook app which is fixed already and will be released in v383. Please refer the issue details in #2114

ArsalImam avatar Sep 12 '22 16:09 ArsalImam

It is available now in the new release: https://github.com/facebook/facebook-ios-sdk/issues/2114#issuecomment-1244843458

ankitpunchh avatar Sep 13 '22 08:09 ankitpunchh

Closing as fixed per #2114

samodom avatar Sep 20 '22 21:09 samodom