facebook-ios-sdk icon indicating copy to clipboard operation
facebook-ios-sdk copied to clipboard

12.2.1 Memory Leak

Open Sunrise17 opened this issue 3 years ago • 5 comments

Checklist before submitting a bug report

Xcode version

13.2

Facebook iOS SDK version

12.2.1

Dependency Manager

CocoaPods

SDK Framework

Login

Goals

I have updated login and share pods to 12.2.1 and memory leaked occurred when i have checked from instruments. After i have disabled code ApplicationDelegate.shared.application(application, didFinishLaunchingWithOptions: launchOptions) in AppDelegate, it has gone. It is caused by the FB SDK.

Expected results

Issues happened by FB SDK, needs to be corrected asap.

Actual results

Instruments Leaks Result

Steps to reproduce

No response

Code samples & details

No response

Sunrise17 avatar Dec 16 '21 17:12 Sunrise17

Does this only happen when you open from a web browser? Also, are you able to provide a sample app to reproduce this?

joesus avatar Dec 20 '21 21:12 joesus

I'm getting this same memory leak issue as well on 12.2.1. Noticed when running Instruments in Xcode.

Instruments specifically calls out these areas: FBSDKErrorConfiguration FBSDKErrorRecoveryConfiguration FBSDKServerConfiguration

MrGobert avatar Feb 02 '22 19:02 MrGobert

What is a bug

jfostersn avatar Mar 10 '22 17:03 jfostersn

@Sunrise17 We were able to reproduce a memory leak from the authentication token factory class and have created a possible fix for this issue that we expect to ship in our next release. We will leave this issue open until that release and hope that you'll be able to confirm that it is fixed at that time.

samodom avatar May 03 '22 23:05 samodom

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 02 '22 05:08 github-actions[bot]

I would like for this to be re-opened - the issue is still here and is reproducible. Tested on iOS 16, iPhone 14 emulator. I have downloaded the latest (at the time of writing) swift package facebook-ios-sdk: 15.1.0. The module which is imported in app is Facebook Login.

Run the "Instruments->Leaks" on an empty Swift project - no leaks. But do what OP has said and we immediately get 23 memory leaks:

Screenshot 2022-11-04 at 15 41 52

dxshindeo avatar Nov 04 '22 13:11 dxshindeo

We are still facing the same issue, please let us know if there is any update regarding this.

Anoopkmr1 avatar Mar 08 '23 10:03 Anoopkmr1