facebook-instant-articles-sdk-php icon indicating copy to clipboard operation
facebook-instant-articles-sdk-php copied to clipboard

support for php-8

Open jeffochoa opened this issue 3 years ago • 9 comments

Adding support for php8

jeffochoa avatar Nov 17 '21 11:11 jeffochoa

Hi @jeffochoa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 17 '21 11:11 facebook-github-bot

Hi @jeffochoa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

done!

jeffochoa avatar Nov 17 '21 12:11 jeffochoa

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Nov 17 '21 13:11 facebook-github-bot

this pull request will merge?

iLexN avatar Jan 26 '22 07:01 iLexN

Looks good +1 on review

vincentkoc avatar Jan 27 '22 05:01 vincentkoc

Looks good

mAlkhatieb avatar Mar 16 '22 17:03 mAlkhatieb

+1

vincentkoc avatar Apr 06 '22 09:04 vincentkoc

+1

lloricode avatar Apr 20 '22 03:04 lloricode

hello @pestevez, any hope that it will be merged soon?

vladsolntsev avatar Apr 03 '23 15:04 vladsolntsev