facebook-business-sdk-codegen icon indicating copy to clipboard operation
facebook-business-sdk-codegen copied to clipboard

Minor fixes on /lib

Open PHBourquin opened this issue 1 year ago • 1 comments

Also with a minor README.md update that isn't intuitive

Checklist

Pull Request Details

Following https://github.com/facebook/facebook-business-sdk-codegen/issues/79, this fixes 2 minor issues in the lib/ files along + a small READM.md update. Indeed, it wasn't implicit as an external contributor that I had to checkout the SDKs and update version_path.json base path towards them to be able to generate the clients, and this bit of information would have been welcome :)

PHBourquin avatar Oct 19 '23 13:10 PHBourquin

Hi @PHBourquin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 20 '23 09:10 facebook-github-bot