facebook-business-sdk-codegen
facebook-business-sdk-codegen copied to clipboard
SDK Codegen patches are not working as expected ?
Checklist
- [X] I've updated to the latest released version
- [X] I've searched for existing GitHub issues
- [X] I've looked for existing answers on Stack Overflow and the Facebook Developers Group
- [X] I've read the Code of Conduct
- [X] This issue is not security related and can safely be disclosed publicly on GitHub
Goals
Following my pull request : https://github.com/facebook/facebook-business-sdk-codegen/pull/75
I have checked the different typed versions ( java
, python
, php
, ruby
)
I think the patch in the file SDKCodegen.json is not working as expected during the SDK generation.
"LeadgenForm": {
"$.fields[?(@.name=='tracking_parameters')]": {
"keyvalue": true
}
},
Expected vs Actual Results
✅ JAVA
Got = Expected
private List<KeyValue> mTrackingParameters = null;
🛑 PHP
Got :
'tracking_parameters' => 'list<map<string, string>>',
Expected
'tracking_parameters' => 'list<KeyValue>',
🛑 PYTHON
Got :
'tracking_parameters': 'list<map<string, string>>',
Expected
'tracking_parameters': 'list<KeyValue>',
🛑 RUBY
Got :
field :tracking_parameters, { list: 'hash' }
Expected :
field :tracking_parameters, { list: 'KeyValue' }
I don't know yet if the other patches are working properly for other adobjects.
Best Regards