facebook
bumping aeson and making compilation work
Hi @L0neGamer!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Not a maintainer, but my unsolicited review:
- Arguably this could be made DRYer by having a single
.Compatmodule where theCPPis hidden, rather than replicating the same fix all over the place; -
KeyMaphas aMonoidinstance, so you could replace thoseKM.emptywith simplymemptywhich I think should work for older versions ofaeson(defaulting to theHashMapinstance);
@chessai This is not perfect but it would be nice to merge it (even if it means a follow-up is needed to clean it up), as it would be extremely nice to have the aeson-2 story under control.
(I'm available to shepherd this issue, if needed, as such patch would benefit my work as well).
@adinapoli Hi, I made the changes as requested, and as a result everything looks much nicer.
Great! I'm happy that my suggestions turned out to be useful.
As said before, unfortunately I'm not a project maintainer, but I hope somebody will be able to review this one properly soon.
On Sat, 23 Dec 2023, 12:05 L0neGamer, @.***> wrote:
@adinapoli https://github.com/adinapoli Hi, I made the changes as requested, and as a result everything looks much nicer.
— Reply to this email directly, view it on GitHub https://github.com/facebook/duckling/pull/724#issuecomment-1868270097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADL5M3N5I7XFNHB34YTZPLYK23JBAVCNFSM6AAAAAA5ASP3FOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGI3TAMBZG4 . You are receiving this because you were mentioned.Message ID: @.***>
@stroxler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.