duckling
duckling copied to clipboard
Enhancement + Fixes for Hebrew Language - Duration+TimeGrain+Time+Amount
("idanadut" fork commit)
Handled preposition, hebrew plural forms, grammer miseaks and added support for new cases that are different from the "english language format" that some of the rules had to the correct Hebrew form.
Mostly these enhancement are about new hebrew grammer options to write time intervals, catch simple times correcly, and handle more complex forms. All changes were tested carefully and extensively to verify all cases (and some tests added to corpus) -> examples: Phrases such as "ב15 לחודש" (which mean "on the 15th of this month"), "שנה שעברה" (which means "last year"), "לפני שלושה חודשים" (which means "three months ago"), "חצי שנה אחרונה" ("past half a year"), "בין 15 לנובמבר לבין 18 לדצמבר" ("between 15th of November to 18th of December") - will now work correctly!
What does it mean that the Travis CI build failed("The command "cabal check" exited with 1.")? One build did succeed and build was fine on local. what changes do I need to make?
The travis build has a simple fix (https://github.com/facebook/duckling/pull/406/commits/361cf01d8b8e9a56189d76806c26fc077f14d5c6) but it seems PR are not being reviewed/merged in this project anymore. (Edit: the commit is now merged)
@idanadut can this be split into separate PRs? one per dimension?
@chessai Yes, sure. I'm not sure I'll be able to get to it any time soon , so you are welcome to do so if you'd like.