docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

feat(swizzle): added a language prompt when no flag is provided

Open yixiaojiu opened this issue 1 year ago • 3 comments

Pre-flight checklist

Motivation

Following the issue https://github.com/facebook/docusaurus/issues/9402, I created a prompt that just shows up when neither --javascript or --typescript is passed

Usage screenshot

image

Related issues/PRs

https://github.com/facebook/docusaurus/issues/9402

yixiaojiu avatar Dec 29 '23 03:12 yixiaojiu

Hi @yixiaojiu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 29 '23 03:12 facebook-github-bot

[V2]

Name Link
Latest commit 5a74613a5d7396cca835c71efeed6ea1880ef7b0
Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65ce0da5969ce80008c34e99
Deploy Preview https://deploy-preview-9681--docusaurus-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 29 '23 03:12 netlify[bot]

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 89 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 65 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

github-actions[bot] avatar Dec 29 '23 03:12 github-actions[bot]

Thanks, LGTM 👍

This will be in v3.2

I refactored a bit, deduplicating the prompting util extracted in https://github.com/facebook/docusaurus/pull/9442

Also:

  • asking for language after choosing theme
  • do not prompt if theme only supports JS
  • throw if theme only supports JS and user provides --typescript option

slorber avatar Feb 15 '24 12:02 slorber