docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

feat(create-docusaurus): added a language prompt when no flag is provided

Open Rafael-Martins opened this issue 2 years ago â€Ē 5 comments

Pre-flight checklist

Motivation

Following the issue #9401, I created a prompt that just shows up when neither --javascript or --typescript is passed

Usage screenshot

image

Related issues/PRs

#9401

Rafael-Martins avatar Oct 24 '23 00:10 Rafael-Martins

Hi @Rafael-Martins!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 24 '23 00:10 facebook-github-bot

[V2]

Name Link
Latest commit fd41b616f88aad2c03a9bcfd845326aa490251e5
Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65cdfaa2d4de890008aa1172
Deploy Preview https://deploy-preview-9442--docusaurus-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 24 '23 00:10 netlify[bot]

⚡ïļ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 ðŸŸĒ 98 ðŸŸĒ 96 ðŸŸĒ 100 🟠 88 Report
/docs/installation 🟠 89 ðŸŸĒ 96 ðŸŸĒ 100 ðŸŸĒ 100 🟠 88 Report
/docs/category/getting-started 🟠 76 ðŸŸĒ 100 ðŸŸĒ 100 ðŸŸĒ 90 🟠 88 Report
/blog 🟠 71 ðŸŸĒ 100 ðŸŸĒ 100 ðŸŸĒ 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 ðŸŸĒ 96 ðŸŸĒ 100 ðŸŸĒ 100 🟠 88 Report
/blog/tags/release 🟠 71 ðŸŸĒ 100 ðŸŸĒ 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 ðŸŸĒ 100 ðŸŸĒ 100 ðŸŸĒ 90 🟠 88 Report

github-actions[bot] avatar Oct 24 '23 00:10 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Oct 24 '23 01:10 facebook-github-bot

Hey @slorber, I addressed the comments above, let me now if we can improve it even more!

Rafael-Martins avatar Oct 25 '23 19:10 Rafael-Martins

Thanks 👍

I took the opportunity to refactor a bit the CLI because it was quite messy ðŸĪŠ

Also adjusting the way we prompt for the language choice because we are going to share some code with another related PR: https://github.com/facebook/docusaurus/pull/9681

will be in v3.2

slorber avatar Feb 15 '24 12:02 slorber