docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

collapsing a sidebar erroneously shows a collapse animation for open sub-items

Open SheetJSDev opened this issue 2 years ago • 2 comments

Have you read the Contributing Guidelines on issues?

Prerequisites

  • [X] I'm using the latest version of Docusaurus.
  • [X] I have tried the npm run clear or yarn clear command.
  • [X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • [ ] I have tried creating a repro with https://new.docusaurus.io.
  • [X] I have read the console error message carefully (if applicable).

Description

When a sidebar has nested sections, collapsing the parent also shows the animation for the children icons.

https://user-images.githubusercontent.com/6070939/210901282-c0ba9a5d-c5f0-411c-9392-aaacbfb3776c.mov

Notice how the icon to the right of "iOS and Android Apps" spins even though the parent "Demos" block is collapsing.

It is surprising because the nested groups are not collapsed when the parent group is uncollapsed.

Reproducible demo

https://git.sheetjs.com/sheetjs/docs.sheetjs.com

Steps to reproduce

Visit https://docs.sheetjs.com/docs/demos/mobile/ on a computer and click the chevron next to "Demos". Observe that two icons rotate

Expected behavior

Only the Demos chevron rotates (since the inner block does not collapse when you expand the Demos group again)

Actual behavior

Both chevrons rotate

Your environment

  • Public source code: https://git.sheetjs.com/sheetjs/docs.sheetjs.com
  • Public site URL: https://docs.sheetjs.com/docs/demos/mobile/
  • Docusaurus version used: 2.2.0
  • Environment name and version (e.g. Chrome 89, Node.js 16.4): Chrome 108
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS): macOS 12.6

Self-service

  • [ ] I'd be willing to fix this bug myself.

SheetJSDev avatar Jan 05 '23 23:01 SheetJSDev

This has been the behavior since (probably) forever. It needs to be fixed in Infima if people feel strongly about it. Looks like we should only select the direct descendent caret to be rotated?

Josh-Cena avatar Jan 10 '23 20:01 Josh-Cena

item/#8512

CoderSantosh1 avatar Oct 12 '23 19:10 CoderSantosh1