docusaurus icon indicating copy to clipboard operation
docusaurus copied to clipboard

refactor(theme-translation): Improve Japanese theme default translation

Open pasora opened this issue 3 years ago • 4 comments

Pre-flight checklist

  • [x] I have read the Contributing Guidelines on pull requests.
  • [ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • [ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I'd like to complete the Japanese default translations before proceeding to the Crowdin works.

Test Plan

Test links

Deploy preview: https://deploy-preview-8075--docusaurus-2.netlify.app/

Related issues/PRs

pasora avatar Sep 09 '22 14:09 pasora

Hi @pasora!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 09 '22 14:09 facebook-github-bot

[V2]

Built without sensitive environment variables

Name Link
Latest commit 05233d2248f075bdeaf7120f9657ff6e9243c7d3
Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/631b488717a6e8000a5b1bfb
Deploy Preview https://deploy-preview-8075--docusaurus-2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 09 '22 14:09 netlify[bot]

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

github-actions[bot] avatar Sep 09 '22 14:09 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Sep 09 '22 16:09 facebook-github-bot

LGTM thanks 👍

slorber avatar Sep 29 '22 10:09 slorber